Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Secondary Media Info & Media Info Stats #5938

Merged

Conversation

grafixeyehero
Copy link
Member

This PR converts the existing mediainfo getSecondaryMediaInfoHtml and getMediaInfoStats to React.

Changes

  • Update PrimaryMediaInfo option naming
  • Add more option for PrimaryMediaInfo
  • Add Secondary Media Info
  • Add Media Info Stats

@grafixeyehero grafixeyehero added the typescript PRs or issues relating to TypeScript code label Aug 21, 2024
@grafixeyehero grafixeyehero requested a review from a team as a code owner August 21, 2024 22:09
Copy link

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit b681e5a1c812026af2a14c6ea466dd98167245d2
Status ✅ Deployed!
Preview URL https://05cc8491.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill
Copy link
Member

Is the secondary info currently displayed anywhere?

@grafixeyehero
Copy link
Member Author

grafixeyehero commented Aug 28, 2024

Is the secondary info currently displayed anywhere?

currently the converted secondary info is not implemented yet this is PR is related to upcoming detail page react view

1.detail page

mediaInfo.fillSecondaryMediaInfo(miscInfo, item, {

2.video page

const secondaryMediaInfoHtml = mediaInfo.getSecondaryMediaInfoHtml(displayItem, {

3.recordingcreator component

context.querySelector('.itemMiscInfoSecondary').innerHTML = mediaInfo.getSecondaryMediaInfoHtml(program, {

@thornbill thornbill added this to the v10.10.0 milestone Sep 4, 2024
@thornbill thornbill merged commit e528847 into jellyfin:master Sep 4, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript PRs or issues relating to TypeScript code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants